[webkit-reviews] review granted: [Bug 186306] Rename color-filter to -apple-color-filter and do not expose it to Web content : [Attachment 342039] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Antoine Quint
<graouts at apple.com>'s request for review:
Bug 186306: Rename color-filter to -apple-color-filter and do not expose it to
Web content
https://bugs.webkit.org/show_bug.cgi?id=186306

Attachment 342039: Patch

https://bugs.webkit.org/attachment.cgi?id=342039&action=review




--- Comment #8 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 342039
  --> https://bugs.webkit.org/attachment.cgi?id=342039
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=342039&action=review

> Source/WebKit/UIProcess/API/C/WKPreferencesRefPrivate.h:570
> +WK_EXPORT void WKPreferencesSetColorFilterEnabled(WKPreferencesRef
preferencesRef, bool flag);
> +WK_EXPORT bool WKPreferencesGetColorFilterEnabled(WKPreferencesRef
preferencesRef);

No need to have the preferencesRef name here.

> Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h:73
> + at property (nonatomic, setter=_setColorFilterEnabled:) BOOL
_colorFilterEnabled WK_API_AVAILABLE(macosx(10.14));

This should be a TBA version, and also available in iOS TBA.