[webkit-reviews] review granted: [Bug 186320] attenuationFactor should be in range [0, 1] : [Attachment 341992] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 6 09:06:38 PDT 2018

Jer Noble <jer.noble at apple.com> has granted Jeremy Jones
<jeremyj-wk at apple.com>'s request for review:
Bug 186320: attenuationFactor should be in range [0,1]

Attachment 341992: Patch


--- Comment #4 from Jer Noble <jer.noble at apple.com> ---
Comment on attachment 341992
  --> https://bugs.webkit.org/attachment.cgi?id=341992

View in context: https://bugs.webkit.org/attachment.cgi?id=341992&action=review

>> Source/WebKit/UIProcess/ios/fullscreen/FullscreenTouchSecheuristic.cpp:81
>> +	return std::max(std::min(normalizedTimeDelta * m_weight, 1.0), 0.0);
> So the weight factor is incorrect when you pass some threshold, but with the
clamping, how long must I wait in order for the old influence to be at 0, and
basically we start from scratch? Before, the old influence would end up having
a negative impact.

We set the ramp down speed to 1_s and the weight to 0.1, so it would take 10
seconds until the old influence had negative impact under the old code.

More information about the webkit-reviews mailing list