[webkit-reviews] review granted: [Bug 185584] [macOS] Spelling errors in the middle of an inserted paragraph are not displayed : [Attachment 341987] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 185584: [macOS] Spelling errors in the middle of an inserted paragraph are
not displayed
https://bugs.webkit.org/show_bug.cgi?id=185584

Attachment 341987: Patch

https://bugs.webkit.org/attachment.cgi?id=341987&action=review




--- Comment #3 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 341987
  --> https://bugs.webkit.org/attachment.cgi?id=341987
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=341987&action=review

> Source/WebCore/ChangeLog:25
> +	   non-contiguous spelling correction ranges â see the FIXME in
markMisspellingsAfterTypingToWord for more detail.

Did you mean to put a period between ranges & see?

> Source/WebCore/editing/Editor.cpp:2388
> +	   while (sentenceStart < spellCheckingStart) {

Should we be running this code in old macOS too? Does that even work?

> LayoutTests/editing/spelling/retro-correction-spelling-markers.html:11
> +	   document.getElementById("description").innerHTML = `To manually
test, type <strong>It's muhc to late

Hm.. I think typeCharacterCommand should trigger spell checking in the browser
too.