[webkit-reviews] review granted: [Bug 186324] [Cocoa] Retire DispatchPtr, and add more move semantics and simpler #ifs to other smart pointers : [Attachment 341996] Patch

[bugzilla-daemon at webkit.org]

Anders Carlsson <andersca at apple.com> has granted Darin Adler
<darin at apple.com>'s request for review:
Bug 186324: [Cocoa] Retire DispatchPtr, and add more move semantics and simpler
#ifs to other smart pointers
https://bugs.webkit.org/show_bug.cgi?id=186324

Attachment 341996: Patch

https://bugs.webkit.org/attachment.cgi?id=341996&action=review




--- Comment #2 from Anders Carlsson <andersca at apple.com> ---
Comment on attachment 341996
  --> https://bugs.webkit.org/attachment.cgi?id=341996
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=341996&action=review

> Source/WTF/wtf/RetainPtr.h:118
> -#if defined (__OBJC__) && __has_feature(objc_arc)
> +#if __has_feature(objc_arc)

I think you might have to keep this in RetainPtr, unless __has_feature is
defined away on Windows.