[webkit-reviews] review denied: [Bug 186283] Temporarily Skip JSC stress test failures that are consistently occurring : [Attachment 341981] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 5 11:52:19 PDT 2018


Mark Lam <mark.lam at apple.com> has denied  review:
Bug 186283: Temporarily Skip JSC stress test failures that are consistently
occurring
https://bugs.webkit.org/show_bug.cgi?id=186283

Attachment 341981: Patch

https://bugs.webkit.org/attachment.cgi?id=341981&action=review




--- Comment #2 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 341981
  --> https://bugs.webkit.org/attachment.cgi?id=341981
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=341981&action=review

> JSTests/stress/splay-flash-access.js:1
> +//@skip if $architecture == "x86"

I don't think you should drop the old condition.  This should be //@skip if
$memoryLimited or $architecture == "x86"


More information about the webkit-reviews mailing list