[webkit-reviews] review granted: [Bug 186293] run-testmem should have a dry run option and an option to parse the stdout of executing the dry run : [Attachment 341976] patch

[bugzilla-daemon at webkit.org]

Mark Lam <mark.lam at apple.com> has granted  review:
Bug 186293: run-testmem should have a dry run option and an option to parse the
stdout of executing the dry run
https://bugs.webkit.org/show_bug.cgi?id=186293

Attachment 341976: patch

https://bugs.webkit.org/attachment.cgi?id=341976&action=review




--- Comment #5 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 341976
  --> https://bugs.webkit.org/attachment.cgi?id=341976
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=341976&action=review

r=me with fixes.

> Tools/Scripts/run-testmem:138
>	   filePath = dirPath.join(filename).to_s
> +	   filePath = Pathname.new($scriptPath).join(filename).to_s if
$scriptPath

I think line 137 is unnecessary now.