[webkit-reviews] review granted: [Bug 186287] Rename "Cross-Origin-Options" HTTP header to "Cross-Origin-Window-Policy" : [Attachment 341932] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Jun 4 18:17:37 PDT 2018
youenn fablet <youennf at gmail.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 186287: Rename "Cross-Origin-Options" HTTP header to
"Cross-Origin-Window-Policy"
https://bugs.webkit.org/show_bug.cgi?id=186287
Attachment 341932: Patch
https://bugs.webkit.org/attachment.cgi?id=341932&action=review
--- Comment #4 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 341932
--> https://bugs.webkit.org/attachment.cgi?id=341932
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=341932&action=review
> Source/WebCore/ChangeLog:9
> + CrossOriginWindowPolicy
Not needed
> Source/WebCore/page/AbstractDOMWindow.cpp:41
> AbstractDOMWindow::AbstractDOMWindow(GlobalWindowIdentifier&& identifier)
GlobalWindowIdentifier&& does not seem to bring any advantage over const
GlobalWindowIdentifier& or is it special in some way?
> Source/WebCore/page/AbstractDOMWindow.h:57
> + CrossOriginWindowPolicy crossOriginWindowPolicy() { return
m_crossOriginWindowPolicy; }
const
> Source/WebCore/page/AbstractDOMWindow.h:69
> + CrossOriginWindowPolicy m_crossOriginWindowPolicy;
Can we set the default value here instead of the constructor?
> Source/WebKitLegacy/mac/WebView/WebPreferences.mm:637
> + [NSNumber numberWithBool:NO],
WebKitCrossOriginWindowPolicySupportEnabledPreferenceKey,
Should we set it to true by default for WK1 as well?
> Source/WebKitLegacy/win/WebPreferences.cpp:252
> + CFDictionaryAddValue(defaults,
CFSTR(WebKitCrossOriginWindowPolicySupportEnabledPreferenceKey),
kCFBooleanFalse);
Is there anything preventing us from aligning windows with other ports?
> Tools/DumpRenderTree/mac/DumpRenderTree.mm:865
> + [preferences setCrossOriginWindowPolicySupportEnabled:YES];
If we set it to true in Mac/win, we could remove these lines
More information about the webkit-reviews
mailing list