[webkit-reviews] review granted: [Bug 186289] AR Badging on transparent thumbnail images makes the glyph look really dark : [Attachment 341936] Patch

[bugzilla-daemon at webkit.org]

Anders Carlsson <andersca at apple.com> has granted Dean Jackson
<dino at apple.com>'s request for review:
Bug 186289: AR Badging on transparent thumbnail images makes the glyph look
really dark
https://bugs.webkit.org/show_bug.cgi?id=186289

Attachment 341936: Patch

https://bugs.webkit.org/attachment.cgi?id=341936&action=review




--- Comment #3 from Anders Carlsson <andersca at apple.com> ---
Comment on attachment 341936
  --> https://bugs.webkit.org/attachment.cgi?id=341936
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=341936&action=review

> Source/WebCore/rendering/RenderThemeIOS.mm:1874
> +    // Clip out the circle to only show the shadow

Please add a period to the end of the sentence.

> Source/WebCore/rendering/RenderThemeIOS.mm:1876
> +    CGRect imageRect = static_cast<CGRect>(rect);

Can this be CGRect imageRect { rect }; ?