[webkit-reviews] review granted: [Bug 186258] Simplify and remove some unused video element code (helpful for ARC-compatibility) : [Attachment 341893] Patch

[bugzilla-daemon at webkit.org]

Daniel Bates <dbates at webkit.org> has granted Darin Adler <darin at apple.com>'s
request for review:
Bug 186258: Simplify and remove some unused video element code (helpful for
ARC-compatibility)
https://bugs.webkit.org/show_bug.cgi?id=186258

Attachment 341893: Patch

https://bugs.webkit.org/attachment.cgi?id=341893&action=review




--- Comment #2 from Daniel Bates <dbates at webkit.org> ---
Comment on attachment 341893
  --> https://bugs.webkit.org/attachment.cgi?id=341893
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=341893&action=review

> Source/WebCore/platform/graphics/MediaPlayer.h:211
> +    virtual Vector<RefPtr<PlatformTextTrack>> outOfBandTrackSources() {
return Vector<RefPtr<PlatformTextTrack>>(); }

return { };

> Source/WebCore/platform/graphics/MediaPlayer.h:588
> +    bool m_visible { false };

Can we swap the order of this line and the one below to achieve better
structure packing?

> Source/WebCore/platform/graphics/cocoa/WebCoreDecompressionSession.h:76
> +    unsigned totalVideoFrames() { return m_totalVideoFrames; }

Make this member function const?

> Source/WebCore/platform/graphics/cocoa/WebCoreDecompressionSession.h:77
> +    unsigned droppedVideoFrames() { return m_droppedVideoFrames; }

Ditto.

> Source/WebCore/platform/graphics/cocoa/WebCoreDecompressionSession.h:78
> +    unsigned corruptedVideoFrames() { return m_corruptedVideoFrames; }

Ditto.

> Source/WebCore/platform/graphics/cocoa/WebCoreDecompressionSession.h:79
>      MediaTime totalFrameDelay() { return m_totalFrameDelay; }

Ditto even though it is not part of the patch.

> Source/WebKitLegacy/mac/WebView/WebVideoFullscreenController.mm:115
> +// called once each time we enter full screen. So it should have a differena
name.

differena => different

> Source/WebKitLegacy/mac/WebView/WebVideoFullscreenController.mm:-126
> -	   if (_videoElement->platformMedia().type ==
PlatformMedia::AVFoundationMediaPlayerType) {

Should we assert this?