[webkit-reviews] review denied: [Bug 186228] [ESNext][BigInt] Implement support for "&" : [Attachment 341869] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Jun 3 19:32:42 PDT 2018

Yusuke Suzuki <utatane.tea at gmail.com> has denied Caio Lima
<ticaiolima at gmail.com>'s request for review:
Bug 186228: [ESNext][BigInt] Implement support for "&"

Attachment 341869: Patch


--- Comment #4 from Yusuke Suzuki <utatane.tea at gmail.com> ---
Comment on attachment 341869
  --> https://bugs.webkit.org/attachment.cgi?id=341869

Previously, op_bitand never returns value except for Int32. But this assumption
is broken now. We should do arith-profile things well to emit BitAnd
effectively in DFG.
This means we should profile values (result, and operands) carefully in LLInt
and Baseline as the other arithmetic operations do.
And please measure the performance once it is done :)

And I think we should rename DFG bit op nodes from BitAnd to ArithBitAnd since
later we will add ValueBitAnd. (And we should rename other bit nodes too).

More information about the webkit-reviews mailing list