[webkit-reviews] review granted: [Bug 164904] We should support CreateThis in the FTL : [Attachment 341849] rebased patch

[bugzilla-daemon at webkit.org]

Yusuke Suzuki <utatane.tea at gmail.com> has granted  review:
Bug 164904: We should support CreateThis in the FTL
https://bugs.webkit.org/show_bug.cgi?id=164904

Attachment 341849: rebased patch

https://bugs.webkit.org/attachment.cgi?id=341849&action=review




--- Comment #52 from Yusuke Suzuki <utatane.tea at gmail.com> ---
Comment on attachment 341849
  --> https://bugs.webkit.org/attachment.cgi?id=341849
rebased patch

View in context: https://bugs.webkit.org/attachment.cgi?id=341849&action=review

r=me

> Source/JavaScriptCore/ChangeLog:21
> +	     that the helper was compiled by the DFG, the baseline get_by_id
would not see those cases.

Yeah, this should be fixed!!!

> Source/JavaScriptCore/bytecode/CodeBlock.cpp:1446
> +	   if (JITCode::isOptimizingJIT(jitType())) {
> +	       DFG::CommonData* dfgCommon = m_jitCode->dfgCommon();
> +	       for (auto& pair : dfgCommon->recordedStatuses.calls)
> +		   result.add(pair.first,
ICStatus()).iterator->value.callStatus = pair.second.get();
> +	       for (auto& pair : dfgCommon->recordedStatuses.gets)
> +		   result.add(pair.first, ICStatus()).iterator->value.getStatus
= pair.second.get();
> +	       for (auto& pair : dfgCommon->recordedStatuses.puts)
> +		   result.add(pair.first, ICStatus()).iterator->value.putStatus
= pair.second.get();
> +	       for (auto& pair : dfgCommon->recordedStatuses.ins)
> +		   result.add(pair.first, ICStatus()).iterator->value.inStatus
= pair.second.get();
> +	   }

Yay

> Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:6678
> +    if (Options::usePolyvariantDevirtualization()) {
> +	   CodeBlock* optimizedBlock = m_profiledBlock->replacement();
> +	   m_optimizedContext.optimizedCodeBlock = optimizedBlock;
> +	   if (optimizedBlock) {
> +	       ConcurrentJSLocker locker(optimizedBlock->m_lock);
> +	       optimizedBlock->getICStatusMap(locker, m_optimizedContext.map);
>	   }
>      }
> +    byteCodeParser->m_icContextStack.append(&m_optimizedContext);

Nice.