[webkit-reviews] review granted: [Bug 185989] JavaScriptCore: Disable 32-bit JIT on Windows : [Attachment 341802] Updated Patch

[bugzilla-daemon at webkit.org]

Mark Lam <mark.lam at apple.com> has granted Michael Saboff <msaboff at apple.com>'s
request for review:
Bug 185989: JavaScriptCore: Disable 32-bit JIT on Windows
https://bugs.webkit.org/show_bug.cgi?id=185989

Attachment 341802: Updated Patch

https://bugs.webkit.org/attachment.cgi?id=341802&action=review




--- Comment #9 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 341802
  --> https://bugs.webkit.org/attachment.cgi?id=341802
Updated Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=341802&action=review

r=me if the EWS bots are happy.

> Source/JavaScriptCore/ChangeLog:8
> +	   Made various minor fixes.

I think you should mention that these fixes are so that the CLOOP can work when
COMPUTED_GOTOs is not supported.

> Source/JavaScriptCore/ChangeLog:13
> +	   * llint/LowLevelInterpreter.cpp: Changed the definition of
OFFLINE_ASM_GLOBAL_LABEL to not
> +	   have a case label these aren't opcodes.

Did you mean "... case label because these aren't opcodes"?