[webkit-reviews] review granted: [Bug 186211] Make sure that the fencePort received over IPC has the expected disposition (SEND) : [Attachment 341800] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Brent Fulgham
<bfulgham at webkit.org>'s request for review:
Bug 186211: Make sure that the fencePort received over IPC has the expected
disposition (SEND)
https://bugs.webkit.org/show_bug.cgi?id=186211

Attachment 341800: Patch

https://bugs.webkit.org/attachment.cgi?id=341800&action=review




--- Comment #3 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 341800
  --> https://bugs.webkit.org/attachment.cgi?id=341800
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=341800&action=review

r=me

> Source/WebKit/WebProcess/WebPage/WebPage.cpp:2664
> +    // Check for invalid message receipt. If this is not a send right,
something has
> +    // gone wrong and we should discard this message.

I don't think this comment adds anything. It just kind of restates the code
below.

> Source/WebKit/WebProcess/cocoa/VideoFullscreenManager.mm:568
> +    // Check for invalid message receipt. If this is not a send right,
something has
> +    // gone wrong and we should discard this message.

Ditto.