[webkit-reviews] review granted: [Bug 186104] Stop using StorageTracker.db in LocalStorageDatabaseTracker : [Attachment 341624] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Sihui Liu <sihui_liu at apple.com>'s
request for review:
Bug 186104: Stop using StorageTracker.db in LocalStorageDatabaseTracker
https://bugs.webkit.org/show_bug.cgi?id=186104

Attachment 341624: Patch

https://bugs.webkit.org/attachment.cgi?id=341624&action=review




--- Comment #14 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 341624
  --> https://bugs.webkit.org/attachment.cgi?id=341624
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=341624&action=review

r=me

> Source/WebCore/platform/sql/SQLiteFileSystem.h:60
> +    WEBCORE_EXPORT static String appendDatabaseFileNameToPath(const String&
path, const String& fileName);

This is something that's nice to explain in your ChangeLog. What you've done
here is to call SQLiteFileSystem functions in cases where we used to call
FileSystem functions because SQLiteFileSystem is logically more correct.