[webkit-reviews] review granted: [Bug 186053] [JSC] Add Symbol.prototype.description getter : [Attachment 341497] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jun 1 11:54:38 PDT 2018


Keith Miller <keith_miller at apple.com> has granted Yusuke Suzuki
<utatane.tea at gmail.com>'s request for review:
Bug 186053: [JSC] Add Symbol.prototype.description getter
https://bugs.webkit.org/show_bug.cgi?id=186053

Attachment 341497: Patch

https://bugs.webkit.org/attachment.cgi?id=341497&action=review




--- Comment #6 from Keith Miller <keith_miller at apple.com> ---
Comment on attachment 341497
  --> https://bugs.webkit.org/attachment.cgi?id=341497
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=341497&action=review

r=me.

> Source/JavaScriptCore/runtime/SymbolPrototype.cpp:78
> +static inline Symbol* tryExtractSymbol(VM& vm, JSValue thisValue)

Nit: I don't think you need the static here.


More information about the webkit-reviews mailing list