[webkit-reviews] review granted: [Bug 186168] Regression(r230876): Swipe navigation snapshot may get removed too early : [Attachment 341767] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jun 1 11:44:59 PDT 2018


Tim Horton <thorton at apple.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 186168: Regression(r230876): Swipe navigation snapshot may get removed too
early
https://bugs.webkit.org/show_bug.cgi?id=186168

Attachment 341767: Patch

https://bugs.webkit.org/attachment.cgi?id=341767&action=review




--- Comment #18 from Tim Horton <thorton at apple.com> ---
Comment on attachment 341767
  --> https://bugs.webkit.org/attachment.cgi?id=341767
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=341767&action=review

> Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:2832
> +- (void)_didStartProvisionalLoadForMainFrame

Are we going to get this if we’re coming from the page cache? (I hope so!)


More information about the webkit-reviews mailing list