[webkit-reviews] review granted: [Bug 185803] [DFG] InById should be converted to MatchStructure : [Attachment 341571] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jun 1 11:16:22 PDT 2018

Keith Miller <keith_miller at apple.com> has granted Yusuke Suzuki
<utatane.tea at gmail.com>'s request for review:
Bug 185803: [DFG] InById should be converted to MatchStructure

Attachment 341571: Patch


--- Comment #9 from Keith Miller <keith_miller at apple.com> ---
Comment on attachment 341571
  --> https://bugs.webkit.org/attachment.cgi?id=341571

View in context: https://bugs.webkit.org/attachment.cgi?id=341571&action=review


> Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:6458
> +			   data->variants.append(matchVariant);

Nit: Not that it matters now but we should probably WTFMove(matchVariant)

More information about the webkit-reviews mailing list