[webkit-reviews] review granted: [Bug 185803] [DFG] InById should be converted to MatchStructure : [Attachment 341571] Patch

[bugzilla-daemon at webkit.org]

Keith Miller <keith_miller at apple.com> has granted Yusuke Suzuki
<utatane.tea at gmail.com>'s request for review:
Bug 185803: [DFG] InById should be converted to MatchStructure
https://bugs.webkit.org/show_bug.cgi?id=185803

Attachment 341571: Patch

https://bugs.webkit.org/attachment.cgi?id=341571&action=review




--- Comment #9 from Keith Miller <keith_miller at apple.com> ---
Comment on attachment 341571
  --> https://bugs.webkit.org/attachment.cgi?id=341571
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=341571&action=review

r=me.

> Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:6458
> +			   data->variants.append(matchVariant);

Nit: Not that it matters now but we should probably WTFMove(matchVariant)