[webkit-reviews] review granted: [Bug 186196] [JSC] Correct values and members of JSBigInt appropriately : [Attachment 341763] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jun 1 10:26:33 PDT 2018

Darin Adler <darin at apple.com> has granted Yusuke Suzuki
<utatane.tea at gmail.com>'s request for review:
Bug 186196: [JSC] Correct values and members of JSBigInt appropriately

Attachment 341763: Patch


--- Comment #2 from Darin Adler <darin at apple.com> ---
Comment on attachment 341763
  --> https://bugs.webkit.org/attachment.cgi?id=341763

View in context: https://bugs.webkit.org/attachment.cgi?id=341763&action=review

> Source/JavaScriptCore/ChangeLog:11
> +	   2. JSBigInt::allocationSize should be annotated with `inline`.

Does this have any effect? Recently I’ve discovered that for the latest
versions of clang, at least, "inline" really means "permission to define this
in multiple translation units" or in other words "this function is in a
header", and isn’t having an effect on what actually gets inlined.

> Source/JavaScriptCore/runtime/JSBigInt.cpp:1309
> -    ASSERT(msdTopBit == (xBitLength - 1) % digitBits);
> +    ASSERT(msdTopBit == static_cast<int>((xBitLength - 1) % digitBits));

Why this change?

More information about the webkit-reviews mailing list