[webkit-reviews] review granted: [Bug 188107] [iOS] Spelling suggestions cannot be selected in focused form controls when zoomed in : [Attachment 346250] Adjust layout test

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 31 21:28:58 PDT 2018


Daniel Bates <dbates at webkit.org> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 188107: [iOS] Spelling suggestions cannot be selected in focused form
controls when zoomed in
https://bugs.webkit.org/show_bug.cgi?id=188107

Attachment 346250: Adjust layout test

https://bugs.webkit.org/attachment.cgi?id=346250&action=review




--- Comment #14 from Daniel Bates <dbates at webkit.org> ---
Comment on attachment 346250
  --> https://bugs.webkit.org/attachment.cgi?id=346250
Adjust layout test

View in context: https://bugs.webkit.org/attachment.cgi?id=346250&action=review

Thank you Wenson for fixing the test.

> LayoutTests/fast/forms/ios/click-should-not-suppress-misspelling.html:25
> +description(`To manually test, tap the input field to bring up the keyboard,
and then tap on a part of the word in

Please start this description with the purpose of the test. For example, in
<https://trac.webkit.org/browser/webkit/trunk/LayoutTests/fast/events/fire-mous
edown-while-pressing-mouse-button-expected.txt> the description starts with
"This test verifies that we fire a mousedown event whenever pressing and
holding a mouse button...".

Minor: No need to use grave quotes as we do need any string interpolation.
Double quotes are sufficient.


More information about the webkit-reviews mailing list