[webkit-reviews] review granted: [Bug 188139] REGRESSION (r231107): MoviStar+ launches to a blank black screen : [Attachment 346247] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Jul 31 20:30:37 PDT 2018
Brent Fulgham <bfulgham at webkit.org> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 188139: REGRESSION (r231107): MoviStar+ launches to a blank black screen
https://bugs.webkit.org/show_bug.cgi?id=188139
Attachment 346247: Patch
https://bugs.webkit.org/attachment.cgi?id=346247&action=review
--- Comment #23 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 346247
--> https://bugs.webkit.org/attachment.cgi?id=346247
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=346247&action=review
Let’s take this change as is, and revisit for other impacted client
applications if any are identified,
>> Source/WebCore/loader/DocumentThreadableLoader.cpp:188
>> + bool needsPreflightQuirk = IOSApplication::isMoviStarPlus() &&
applicationSDKVersion() < DYLD_IOS_VERSION_12_0 && (m_options.preflightPolicy
== PreflightPolicy::Consider || m_options.preflightPolicy ==
PreflightPolicy::Force);
>
> How did you come to the decision to limit this change only to MoviStar? This
issue affects all apps. It seems weird to give preferential treatment to
MoviStar and will give a bad customer experience for other Mac and iOS apps
affected by r231107.
Do we know of any other clients impacted by this? Alex and I talked about it,
and would like to be able to remove this workaround code once MoviStar (and any
others) have updated.
More information about the webkit-reviews
mailing list