[webkit-reviews] review granted: [Bug 187108] Add configuration for automatic process pre-warming : [Attachment 346239] Patch for landing

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Ben Richards
<benton_richards at apple.com>'s request for review:
Bug 187108: Add configuration for automatic process pre-warming
https://bugs.webkit.org/show_bug.cgi?id=187108

Attachment 346239: Patch for landing

https://bugs.webkit.org/attachment.cgi?id=346239&action=review




--- Comment #27 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 346239
  --> https://bugs.webkit.org/attachment.cgi?id=346239
Patch for landing

View in context: https://bugs.webkit.org/attachment.cgi?id=346239&action=review

> Source/WebKit/ChangeLog:25
> +	   (WebKit::WebProcessPool::setMaximumNumberOfProcesses): Condition
changed so that warmInitialProcess doesn't result in a crash if called before
this function.

warmInitialProcess itself doesn't crash but calling setMaximumNumberOfProcesses
would.

> Tools/TestWebKitAPI/Tests/WebKitCocoa/SetMaximumPrewarmedProcessCount.mm:2
> + * Copyright (C) 2017 Apple Inc. All rights reserved.

This should be 2018.