[webkit-reviews] review granted: [Bug 186751] Remove the SVG elements' attributes macros : [Attachment 346244] Remove SVG macros from SVGRectElement

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Said Abou-Hallawa
<sabouhallawa at apple.com>'s request for review:
Bug 186751: Remove the SVG elements' attributes macros
https://bugs.webkit.org/show_bug.cgi?id=186751

Attachment 346244: Remove SVG macros from SVGRectElement

https://bugs.webkit.org/attachment.cgi?id=346244&action=review




--- Comment #107 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 346244
  --> https://bugs.webkit.org/attachment.cgi?id=346244
Remove SVG macros from SVGRectElement

View in context: https://bugs.webkit.org/attachment.cgi?id=346244&action=review

> Source/WebCore/svg/SVGRectElement.h:74
> +    AttributeOwnerProxy m_attributeOwnerProxy { *this };
> +    SVGAnimatedLengthAttribute m_x { m_attributeOwnerProxy, LengthModeWidth
};
> +    SVGAnimatedLengthAttribute m_y { m_attributeOwnerProxy, LengthModeHeight
};
> +    SVGAnimatedLengthAttribute m_width { m_attributeOwnerProxy,
LengthModeWidth };
> +    SVGAnimatedLengthAttribute m_height { m_attributeOwnerProxy,
LengthModeHeight };
> +    SVGAnimatedLengthAttribute m_rx { m_attributeOwnerProxy, LengthModeWidth
};
> +    SVGAnimatedLengthAttribute m_ry { m_attributeOwnerProxy,
LengthModeHeight};

How does the size of SVGRectElement change (use dump-class-layout to tell).