[webkit-reviews] review granted: [Bug 186751] Remove the SVG elements' attributes macros : [Attachment 346241] Register SVGExternalResourcesRequired attributes into SVGAttributeRegistry

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Said Abou-Hallawa
<sabouhallawa at apple.com>'s request for review:
Bug 186751: Remove the SVG elements' attributes macros
https://bugs.webkit.org/show_bug.cgi?id=186751

Attachment 346241: Register SVGExternalResourcesRequired attributes into
SVGAttributeRegistry

https://bugs.webkit.org/attachment.cgi?id=346241&action=review




--- Comment #106 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 346241
  --> https://bugs.webkit.org/attachment.cgi?id=346241
Register SVGExternalResourcesRequired attributes into SVGAttributeRegistry

View in context: https://bugs.webkit.org/attachment.cgi?id=346241&action=review

> Source/WebCore/svg/SVGExternalResourcesRequired.cpp:30
> +SVGExternalResourcesRequired::SVGExternalResourcesRequired(SVGElement*
contextElement)

Can contextElement be a reference?

> Source/WebCore/svg/SVGExternalResourcesRequired.cpp:69
> +    if (renderer && is<RenderSVGShape>(renderer)) {

Again more RenderSVGShape specialness. Why?