[webkit-reviews] review granted: [Bug 188124] [iOS] WKColorPicker's selection indicator doesn't always cover the selected swatch : [Attachment 346236] Patch

[bugzilla-daemon at webkit.org]

Wenson Hsieh <wenson_hsieh at apple.com> has granted Aditya Keerthi
<akeerthi at apple.com>'s request for review:
Bug 188124: [iOS] WKColorPicker's selection indicator doesn't always cover the
selected swatch
https://bugs.webkit.org/show_bug.cgi?id=188124

Attachment 346236: Patch

https://bugs.webkit.org/attachment.cgi?id=346236&action=review




--- Comment #11 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 346236
  --> https://bugs.webkit.org/attachment.cgi?id=346236
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=346236&action=review

> Source/WebKit/UIProcess/ios/forms/WKFormColorPicker.mm:225
> +	   bool minXEqual = CGFAbs(CGRectGetMinX(frame) -
CGRectGetMinX(colorPickerBounds)) < FLT_EPSILON;

Nit - we generally prefer using std::abs here, instead of the CG equivalent.