[webkit-reviews] review granted: [Bug 186751] Remove the SVG elements' attributes macros : [Attachment 346193] Delete SVG macros for SVGAnimatedEnumeration

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 31 17:34:26 PDT 2018


Simon Fraser (smfr) <simon.fraser at apple.com> has granted Said Abou-Hallawa
<sabouhallawa at apple.com>'s request for review:
Bug 186751: Remove the SVG elements' attributes macros
https://bugs.webkit.org/show_bug.cgi?id=186751

Attachment 346193: Delete SVG macros for SVGAnimatedEnumeration

https://bugs.webkit.org/attachment.cgi?id=346193&action=review




--- Comment #97 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 346193
  --> https://bugs.webkit.org/attachment.cgi?id=346193
Delete SVG macros for SVGAnimatedEnumeration

View in context: https://bugs.webkit.org/attachment.cgi?id=346193&action=review

> Source/WebCore/svg/SVGAnimatedEnumeration.h:31
> +using SVGAnimatedEnumeration = SVGAnimatedStaticPropertyTearOff<unsigned>;

Will this still cause problems with 8-bit enum classes? Do we eventually need
to provide tear-off types for each unique enum class?


More information about the webkit-reviews mailing list