[webkit-reviews] review granted: [Bug 188124] [iOS] WKColorPicker's selection indicator doesn't always cover the selected swatch : [Attachment 346223] Patch

[bugzilla-daemon at webkit.org]

Wenson Hsieh <wenson_hsieh at apple.com> has granted Aditya Keerthi
<akeerthi at apple.com>'s request for review:
Bug 188124: [iOS] WKColorPicker's selection indicator doesn't always cover the
selected swatch
https://bugs.webkit.org/show_bug.cgi?id=188124

Attachment 346223: Patch

https://bugs.webkit.org/attachment.cgi?id=346223&action=review




--- Comment #6 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 346223
  --> https://bugs.webkit.org/attachment.cgi?id=346223
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=346223&action=review

> Source/WebKit/UIProcess/ios/forms/WKFormColorPicker.mm:216
> +    _selectedColorButton = colorButton;

This looks like it'll get called many times, for every tick of the pan gesture
recognizer. Is it possible to bail here if the selected color button hasn't
actually changed, or do we always need to do this work?