[webkit-reviews] review granted: [Bug 188207] [iOS] Color picker should have a border when presented in a popover : [Attachment 346214] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 31 16:37:34 PDT 2018


Wenson Hsieh <wenson_hsieh at apple.com> has granted Aditya Keerthi
<akeerthi at apple.com>'s request for review:
Bug 188207: [iOS] Color picker should have a border when presented in a popover
https://bugs.webkit.org/show_bug.cgi?id=188207

Attachment 346214: Patch

https://bugs.webkit.org/attachment.cgi?id=346214&action=review




--- Comment #5 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 346214
  --> https://bugs.webkit.org/attachment.cgi?id=346214
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=346214&action=review

> Source/WebKit/ChangeLog:11
> +	   Since the popover will resize it's view to fill it's size, we first
place the

Super nit — it's => its

> Source/WebKit/ChangeLog:13
> +	   while the smaller color picker is centered in it's container -
creating the

Here too.


More information about the webkit-reviews mailing list