[webkit-reviews] review granted: [Bug 185398] Web Inspector: split-up async stack trace test suite to improve clarity and maintainability : [Attachment 340227] Patch

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has granted Matt Baker
<mattbaker at apple.com>'s request for review:
Bug 185398: Web Inspector: split-up async stack trace test suite to improve
clarity and maintainability
https://bugs.webkit.org/show_bug.cgi?id=185398

Attachment 340227: Patch

https://bugs.webkit.org/attachment.cgi?id=340227&action=review




--- Comment #13 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 340227
  --> https://bugs.webkit.org/attachment.cgi?id=340227
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=340227&action=review

Nice! r=me

> LayoutTests/inspector/debugger/async-stack-trace-basic.html:34
> +function triggerNestedSetTimeout() {
> +    setTimeout(function handleTimeout1() {
> +	   setTimeout(function handleTimeout2() {
> +	       debugger;
> +	   });
> +    });
> +}

This is so very clean =)

> LayoutTests/inspector/debugger/async-stack-trace-basic.html:70
> +	   expression: "triggerRequestAnimationFrame()",

Nit: We normally make strings that contain code templated strings. So use ``s
instead of ""s. This ends up being convenient if your editor highlights strings
and templated strings slightly differently, then the code snippets stand out!

> LayoutTests/inspector/debugger/async-stack-trace-truncate.html:82
> +	   name: "AsyncStackTrace.",
> +	   description: "",

More descriptive title?