[webkit-reviews] review granted: [Bug 188201] [JSC] Remove unnecessary cellLock() in JSObject's GC marking if IndexingType is contiguous : [Attachment 346181] Patch

[bugzilla-daemon at webkit.org]

Keith Miller <keith_miller at apple.com> has granted Yusuke Suzuki
<utatane.tea at gmail.com>'s request for review:
Bug 188201: [JSC] Remove unnecessary cellLock() in JSObject's GC marking if
IndexingType is contiguous
https://bugs.webkit.org/show_bug.cgi?id=188201

Attachment 346181: Patch

https://bugs.webkit.org/attachment.cgi?id=346181&action=review




--- Comment #2 from Keith Miller <keith_miller at apple.com> ---
Comment on attachment 346181
  --> https://bugs.webkit.org/attachment.cgi?id=346181
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=346181&action=review

r=me.

> Source/JavaScriptCore/runtime/JSObject.cpp:400
> +	   // that can happen when the butterfly is used for array storage.

Nit: Add a comment here repeating what you said in the change log about always
reallocating the butterfly when converting to ArrayStorage.