[webkit-reviews] review denied: [Bug 188160] server_process.py should print returncode in debug log if the process crashed : [Attachment 346056] Patch

[bugzilla-daemon at webkit.org]

Fujii Hironori <Hironori.Fujii at sony.com> has denied Fujii Hironori
<Hironori.Fujii at sony.com>'s request for review:
Bug 188160: server_process.py should print returncode in debug log if the
process crashed
https://bugs.webkit.org/show_bug.cgi?id=188160

Attachment 346056: Patch

https://bugs.webkit.org/attachment.cgi?id=346056&action=review




--- Comment #4 from Fujii Hironori <Hironori.Fujii at sony.com> ---
Comment on attachment 346056
  --> https://bugs.webkit.org/attachment.cgi?id=346056
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=346056&action=review

Thank you for the review.

>> Tools/Scripts/webkitpy/port/server_process.py:326
>> +		_log.debug('This test marked as a crash because of failure to
poll the server process. (returncode %s)' % self._proc.returncode)
> 
> I think it should say 'This test marked as a crash because of failure to poll
the server process (return code was %).'

Make sense. Will Fix.