[webkit-reviews] review canceled: [Bug 188154] [Curl] Bug fix for pre-supplied credential information handling. : [Attachment 346050] PATCH

[bugzilla-daemon at webkit.org]

Basuke Suzuki <Basuke.Suzuki at sony.com> has canceled Basuke Suzuki
<Basuke.Suzuki at sony.com>'s request for review:
Bug 188154: [Curl] Bug fix for pre-supplied credential information handling.
https://bugs.webkit.org/show_bug.cgi?id=188154

Attachment 346050: PATCH

https://bugs.webkit.org/attachment.cgi?id=346050&action=review




--- Comment #5 from Basuke Suzuki <Basuke.Suzuki at sony.com> ---
Comment on attachment 346050
  --> https://bugs.webkit.org/attachment.cgi?id=346050
PATCH

View in context: https://bugs.webkit.org/attachment.cgi?id=346050&action=review

>> Source/WebCore/platform/network/curl/ResourceHandleCurl.cpp:362
>> +	    d->m_pass = String();
> 
> Why does curl port clear m_user and m_pass twice while Mac port and CF port
do once?
> First in ResourceHandle::didReceiveAuthenticationChallenge and second in
ResourceHandle::getCredential.
> IIUC, m_user and m_pass are used to remember user/pass in URL during the
first request without user/pass.
> It is weird for me that m_user and m_pass are cleared in
ResourceHandle::getCredential.

Right. clearing them in getCredential() isn't required maybe. The crash will be
avoided by moving the clearing of m_user and m_pass causes stack overflow
because everything run in main thread in recursive(). This is not good ...