[webkit-reviews] review granted: [Bug 188139] REGRESSION (r231107): MoviStar+ launches to a blank black screen : [Attachment 346119] Patch and layout tests

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted Daniel Bates
<dbates at webkit.org>'s request for review:
Bug 188139: REGRESSION (r231107): MoviStar+ launches to a blank black screen
https://bugs.webkit.org/show_bug.cgi?id=188139

Attachment 346119: Patch and layout tests

https://bugs.webkit.org/attachment.cgi?id=346119&action=review




--- Comment #10 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 346119
  --> https://bugs.webkit.org/attachment.cgi?id=346119
Patch and layout tests

View in context: https://bugs.webkit.org/attachment.cgi?id=346119&action=review

I think this patch looks good, but it might still cause imported platform Fetch
API tests to fail.

> Source/WebKit/NetworkProcess/NetworkLoadChecker.h:137
> +    bool m_shouldCaptureExtraNetworkLoadMetrics;

We did you stop initializing this value? Is it because it is always set by the
constructor? It seems like it would be better to always set them to a known
state, in case someone makes a constructor overload in the future that doesn't
assign a value here.