[webkit-reviews] review granted: [Bug 186751] Remove the SVG elements' attributes macros : [Attachment 346103] Introduce SVGAttributeAccessor

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Said Abou-Hallawa
<sabouhallawa at apple.com>'s request for review:
Bug 186751: Remove the SVG elements' attributes macros
https://bugs.webkit.org/show_bug.cgi?id=186751

Attachment 346103: Introduce SVGAttributeAccessor

https://bugs.webkit.org/attachment.cgi?id=346103&action=review




--- Comment #62 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 346103
  --> https://bugs.webkit.org/attachment.cgi?id=346103
Introduce SVGAttributeAccessor

View in context: https://bugs.webkit.org/attachment.cgi?id=346103&action=review

> Source/WebCore/svg/properties/SVGAttributeAccessor.h:53
> +    virtual ~SVGAttributeAccessor() = default;

I prefer to see this after the constructor.

> Source/WebCore/svg/properties/SVGAttributeAccessor.h:61
> +    const QualifiedName& m_attributeName;

sizeof(QualifiedName) == sizeof(void*) so maybe you should just store it by
value.