[webkit-reviews] review granted: [Bug 188177] Add missing CoreGraphics SPI : [Attachment 346082] Patch

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has granted Devin Rousso
<webkit at devinrousso.com>'s request for review:
Bug 188177: Add missing CoreGraphics SPI
https://bugs.webkit.org/show_bug.cgi?id=188177

Attachment 346082: Patch

https://bugs.webkit.org/attachment.cgi?id=346082&action=review




--- Comment #2 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 346082
  --> https://bugs.webkit.org/attachment.cgi?id=346082
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=346082&action=review

r=me

> Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:305
> +#if ENABLE(WEBPROCESS_WINDOWSERVER_BLOCKING)

You could probably drop the `ENABLE(WEBPROCESS_WINDOWSERVER_BLOCKING)`
if/endifs. This SPI exists on Mac, regardless of whether or not we decide to
use it based on this feature.