[webkit-reviews] review granted: [Bug 187982] [WebGL2] Support compilation of GLSL ES version 300 shaders : [Attachment 345987] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Jul 30 11:52:18 PDT 2018
Dean Jackson <dino at apple.com> has granted Justin Fan <justin_fan at apple.com>'s
request for review:
Bug 187982: [WebGL2] Support compilation of GLSL ES version 300 shaders
https://bugs.webkit.org/show_bug.cgi?id=187982
Attachment 345987: Patch
https://bugs.webkit.org/attachment.cgi?id=345987&action=review
--- Comment #26 from Dean Jackson <dino at apple.com> ---
Comment on attachment 345987
--> https://bugs.webkit.org/attachment.cgi?id=345987
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=345987&action=review
> LayoutTests/platform/ios-simulator-wk2/TestExpectations:49
> +# We are only accepting GLSL3 for macOS.
> +webkit.org/b/187982 webgl/2.0.0/conformance2/glsl3 [ Skip ]
This should be in platform/ios/TestExpectations not just ios-simulator-wk2
More information about the webkit-reviews
mailing list