[webkit-reviews] review granted: [Bug 188157] Add a debugging utility to dump the memory layout of a JSCell. : [Attachment 346053] proposed patch.

[bugzilla-daemon at webkit.org]

Yusuke Suzuki <utatane.tea at gmail.com> has granted Mark Lam
<mark.lam at apple.com>'s request for review:
Bug 188157: Add a debugging utility to dump the memory layout of a JSCell.
https://bugs.webkit.org/show_bug.cgi?id=188157

Attachment 346053: proposed patch.

https://bugs.webkit.org/attachment.cgi?id=346053&action=review




--- Comment #3 from Yusuke Suzuki <utatane.tea at gmail.com> ---
Comment on attachment 346053
  --> https://bugs.webkit.org/attachment.cgi?id=346053
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=346053&action=review

r=me

> Source/JavaScriptCore/ChangeLog:37
> +		   structureID 369 0x171 structure 0x104b723e0
> +		   indexingTypeAndMisc 11 0xb ArrayWithArrayStorage
> +		   type 33 0x21

It would be nice if we can put classInfo's name too.