[webkit-reviews] review granted: [Bug 188147] Make CompositeOperator and BlendMode into 8-bit enum classes : [Attachment 346029] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 188147: Make CompositeOperator and BlendMode into 8-bit enum classes
https://bugs.webkit.org/show_bug.cgi?id=188147

Attachment 346029: Patch

https://bugs.webkit.org/attachment.cgi?id=346029&action=review




--- Comment #2 from Darin Adler <darin at apple.com> ---
Comment on attachment 346029
  --> https://bugs.webkit.org/attachment.cgi?id=346029
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=346029&action=review

> Source/WebCore/html/HTMLImageElement.cpp:70
> +    , m_compositeOperator(CompositeOperator::SourceOver)

Do this in the header instead?

> Source/WebCore/html/canvas/CanvasRenderingContext2DBase.cpp:202
> +    , globalComposite(CompositeOperator::SourceOver)
> +    , globalBlend(BlendMode::Normal)

Do these in the class definition instead of the constructor?