[webkit-reviews] review granted: [Bug 188099] [WIN] Fix tests for text with initial advances : [Attachment 346007] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Myles C. Maxfield
<mmaxfield at apple.com>'s request for review:
Bug 188099: [WIN] Fix tests for text with initial advances
https://bugs.webkit.org/show_bug.cgi?id=188099

Attachment 346007: Patch

https://bugs.webkit.org/attachment.cgi?id=346007&action=review




--- Comment #12 from Darin Adler <darin at apple.com> ---
Comment on attachment 346007
  --> https://bugs.webkit.org/attachment.cgi?id=346007
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=346007&action=review

> Source/WebCore/platform/graphics/ComplexTextController.cpp:49
> +    WTF_MAKE_FAST_ALLOCATED;

Seems like this is unneeded, since we won‘t ever allocate one.

> Source/WebCore/platform/graphics/FontCascade.cpp:1436
> +    FloatPoint startPoint(point.x() + glyphBuffer.initialAdvance().width(),
point.y() + glyphBuffer.initialAdvance().height());

This can be written like this:

    FloatPoint startPoint { point + glyphBuffer.initialAdvance() };

Or any variant using { }, (), or =, and either FloatPoint or auto. But no
reason to do the x and y separately.