[webkit-reviews] review granted: [Bug 188114] Remove WebGPUObject : [Attachment 345999] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Jul 28 13:40:34 PDT 2018


Darin Adler <darin at apple.com> has granted Sam Weinig <sam at webkit.org>'s request
for review:
Bug 188114: Remove WebGPUObject
https://bugs.webkit.org/show_bug.cgi?id=188114

Attachment 345999: Patch

https://bugs.webkit.org/attachment.cgi?id=345999&action=review




--- Comment #7 from Darin Adler <darin at apple.com> ---
Comment on attachment 345999
  --> https://bugs.webkit.org/attachment.cgi?id=345999
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=345999&action=review

> Source/WebCore/html/canvas/WebGPURenderPassColorAttachmentDescriptor.cpp:43
> +    : WebGPURenderPassAttachmentDescriptor()

I don’t think explicit base class initialization is needed any more in this
constructor.

> Source/WebCore/html/canvas/WebGPURenderPassDepthAttachmentDescriptor.cpp:41
> +    : WebGPURenderPassAttachmentDescriptor()

Ditto.


More information about the webkit-reviews mailing list