[webkit-reviews] review granted: [Bug 188123] Add some crash info to Heap::checkConn() RELEASE_ASSERTs. : [Attachment 345951] proposed patch.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jul 27 14:29:24 PDT 2018

Keith Miller <keith_miller at apple.com> has granted Mark Lam
<mark.lam at apple.com>'s request for review:
Bug 188123: Add some crash info to Heap::checkConn() RELEASE_ASSERTs.

Attachment 345951: proposed patch.


--- Comment #4 from Keith Miller <keith_miller at apple.com> ---
Comment on attachment 345951
  --> https://bugs.webkit.org/attachment.cgi?id=345951
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=345951&action=review


> Source/JavaScriptCore/ChangeLog:10
> +	      padding space in VM and Heap, and should cost any measurable perf
to initialize

should *only* cost?

> Source/WTF/wtf/Assertions.cpp:676
> +void WTFCrashWithInfo(int, const char*, const char*, int, uint64_t,
uint64_t, uint64_t, uint64_t, uint64_t, uint64_t) { CRASH(); }

I think you need another line here.

More information about the webkit-reviews mailing list