[webkit-reviews] review granted: [Bug 188072] Match GraphicsContext3D with correct virtual screen using registryID : [Attachment 345933] Patch

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Justin Fan <justin_fan at apple.com>'s
request for review:
Bug 188072: Match GraphicsContext3D with correct virtual screen using
registryID
https://bugs.webkit.org/show_bug.cgi?id=188072

Attachment 345933: Patch

https://bugs.webkit.org/attachment.cgi?id=345933&action=review




--- Comment #10 from Dean Jackson <dino at apple.com> ---
Comment on attachment 345933
  --> https://bugs.webkit.org/attachment.cgi?id=345933
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=345933&action=review

> Source/WebCore/platform/ScreenProperties.h:49
> +    int64_t registryID { 0 };

Shouldn't this use the PlatformRegistryID typedef?

> Source/WebCore/platform/graphics/cocoa/GraphicsContext3DCocoa.mm:216
> +    // When the WebProcess does not have access to the WindowServer, there
is no way for OpenGL to tell which GPU is connected to a display.
> +    // See code example at
https://developer.apple.com/library/content/technotes/tn2229/_index.html#//appl
e_ref/doc/uid/DTS40008924-CH1-SUBSECTION7

Do we have access to the window server on 10.12?