[webkit-reviews] review granted: [Bug 188062] Reduce unnecessary copying of EditingStyles on ApplyStyleCommand construction : [Attachment 345850] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 26 23:27:42 PDT 2018


Darin Adler <darin at apple.com> has granted Sam Weinig <sam at webkit.org>'s request
for review:
Bug 188062: Reduce unnecessary copying of EditingStyles on ApplyStyleCommand
construction
https://bugs.webkit.org/show_bug.cgi?id=188062

Attachment 345850: Patch

https://bugs.webkit.org/attachment.cgi?id=345850&action=review




--- Comment #4 from Darin Adler <darin at apple.com> ---
Comment on attachment 345850
  --> https://bugs.webkit.org/attachment.cgi?id=345850
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=345850&action=review

> Source/WebCore/ChangeLog:28
> +	   * editing/EditorCommand.cpp:
> +	   (WebCore::executeMakeTextWritingDirectionLeftToRight):
> +	   (WebCore::executeMakeTextWritingDirectionNatural):
> +	   (WebCore::executeMakeTextWritingDirectionRightToLeft):

This is a not-particularly-closely-related (minor) refactoring, not mentioned
in the change log.


More information about the webkit-reviews mailing list