[webkit-reviews] review denied: [Bug 188033] [Curl] Crash on synchronous request via ResourceHandle. : [Attachment 345846] Fix

[bugzilla-daemon at webkit.org]

Fujii Hironori <Hironori.Fujii at sony.com> has denied Basuke Suzuki
<Basuke.Suzuki at sony.com>'s request for review:
Bug 188033: [Curl] Crash on synchronous request via ResourceHandle.
https://bugs.webkit.org/show_bug.cgi?id=188033

Attachment 345846: Fix

https://bugs.webkit.org/attachment.cgi?id=345846&action=review




--- Comment #20 from Fujii Hironori <Hironori.Fujii at sony.com> ---
Comment on attachment 345846
  --> https://bugs.webkit.org/attachment.cgi?id=345846
Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=345846&action=review

In general, you need to setup testing framework before implementing some
features or refactoring to avoid regressions like Bug 188033.

> LayoutTests/platform/wincairo/TestExpectations:850
> +

Don't move this.

> LayoutTests/platform/wincairo/TestExpectations:869
> +http/tests/xmlhttprequest/simple-sync.html [ Pass ]

Remove these two lines if it is too unpractical at the moment.

# XMLHTTPRequest (sync)
http/tests/xmlhttprequest/simple-sync.html [ Crash ]

> LayoutTests/platform/wincairo/TestExpectations:-1574
> -http/tests [ Skip ]

Don't move this.