[webkit-reviews] review granted: [Bug 188081] [INTL] Remove INTL sub-feature compile flags : [Attachment 345880] Patch

[bugzilla-daemon at webkit.org]

Michael Catanzaro <mcatanzaro at igalia.com> has granted Andy VanWagoner
<andy at vanwagoner.family>'s request for review:
Bug 188081: [INTL] Remove INTL sub-feature compile flags
https://bugs.webkit.org/show_bug.cgi?id=188081

Attachment 345880: Patch

https://bugs.webkit.org/attachment.cgi?id=345880&action=review




--- Comment #4 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 345880
  --> https://bugs.webkit.org/attachment.cgi?id=345880
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=345880&action=review

Yay, fewer build flags! This looks good, except perhaps for one bit I have
questions about:

> Source/JavaScriptCore/runtime/Options.h:115
> -#if ENABLE(INTL_NUMBER_FORMAT_TO_PARTS) && (!PLATFORM(COCOA) ||
ENABLE(EXPERIMENTAL_FEATURES))
> +#if (!PLATFORM(COCOA) || ENABLE(EXPERIMENTAL_FEATURES))

So the intention is for these features to be enabled for Apple only if
experimental features are enabled, but enabled on other ports always? Isn't
that pretty weird? What's the reasoning behind this? Are the features expected
to be more stable on non-Apple ports?

Surely this is enabling the feature for WPE/GTK right here?