[webkit-reviews] review granted: [Bug 188079] [ews-build] Add build step to run API Tests : [Attachment 345876] Proposed patch

[bugzilla-daemon at webkit.org]

Lucas Forschler <lforschler at apple.com> has granted Aakash Jain
<aakash_jain at apple.com>'s request for review:
Bug 188079: [ews-build] Add build step to run API Tests
https://bugs.webkit.org/show_bug.cgi?id=188079

Attachment 345876: Proposed patch

https://bugs.webkit.org/attachment.cgi?id=345876&action=review




--- Comment #4 from Lucas Forschler <lforschler at apple.com> ---
Comment on attachment 345876
  --> https://bugs.webkit.org/attachment.cgi?id=345876
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=345876&action=review

r=me as is, with a nit, and something to think about for future patches.

> Tools/BuildSlaveSupport/ews-build/steps.py:378
> +    descriptionDone = ['api-tests']

api tests completed?

> Tools/BuildSlaveSupport/ews-build/steps_unittest.py:871
> +	   self.setProperty('fullPlatform', 'mac-sierra')

some pondering...  mac-highsierra is released, and Mojave is in beta.
Mac-sierra will be the next platform to fall off the supported list. 
I don't think it really matters for unit tests, unless we run into a problem
where the fullPlatform is not in a supported list somewhere...
Do we want to be in the business of updating these periodically as they fall
off, or just be ok with the fact that it will soon reference really stale
releases?

If we try to keep them relevant, then we should be using mac-mojave everywhere,
which would be a larger change in many files.