[webkit-reviews] review granted: [Bug 187379] Add support for fetching and remove type _WKWebsiteDataTypeHSTSCache : [Attachment 345829] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 26 13:12:43 PDT 2018


Geoffrey Garen <ggaren at apple.com> has granted Sihui Liu <sihui_liu at apple.com>'s
request for review:
Bug 187379: Add support for fetching and remove type 
_WKWebsiteDataTypeHSTSCache
https://bugs.webkit.org/show_bug.cgi?id=187379

Attachment 345829: Patch

https://bugs.webkit.org/attachment.cgi?id=345829&action=review




--- Comment #10 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 345829
  --> https://bugs.webkit.org/attachment.cgi?id=345829
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=345829&action=review

r=me

> Source/WebKit/NetworkProcess/cocoa/NetworkProcessCocoa.mm:155
> +    HashSet<String>* hostnames =
reinterpret_cast<HashSet<String>*>(context);

This can be static_cast because void* can static_cast to any pointer.


More information about the webkit-reviews mailing list