[webkit-reviews] review granted: [Bug 188067] Use the Page's appearance when converting pasteboard attributed strings : [Attachment 345856] Patch

[bugzilla-daemon at webkit.org]

Wenson Hsieh <wenson_hsieh at apple.com> has granted Timothy Hatcher
<timothy at apple.com>'s request for review:
Bug 188067: Use the Page's appearance when converting pasteboard attributed
strings
https://bugs.webkit.org/show_bug.cgi?id=188067

Attachment 345856: Patch

https://bugs.webkit.org/attachment.cgi?id=345856&action=review




--- Comment #4 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 345856
  --> https://bugs.webkit.org/attachment.cgi?id=345856
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=345856&action=review

Is this testable in any way?

> Source/WebCore/editing/cocoa/WebContentReaderCocoa.mm:128
> +    auto* page = frame.page();

I was wondering if there's ever a case where page could be null, but it looks
like we're okay here because createFragmentAndAddResources will bail if
!frame.page().