[webkit-reviews] review granted: [Bug 188065] arrayProtoPrivateFuncConcatMemcpy() should handle copying from an Undecided type array. : [Attachment 345853] proposed patch.

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has granted Mark Lam <mark.lam at apple.com>'s
request for review:
Bug 188065: arrayProtoPrivateFuncConcatMemcpy() should handle copying from an
Undecided type array.
https://bugs.webkit.org/show_bug.cgi?id=188065

Attachment 345853: proposed patch.

https://bugs.webkit.org/attachment.cgi?id=345853&action=review




--- Comment #2 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 345853
  --> https://bugs.webkit.org/attachment.cgi?id=345853
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=345853&action=review

> Source/JavaScriptCore/runtime/ArrayPrototype.cpp:1307
> +template<typename T, bool isDouble = std::is_same<T, double>::value>

why do you need isDouble?

> Source/JavaScriptCore/runtime/ArrayPrototype.cpp:1308
> +void copyElements(T* buffer, unsigned offset, void* source, unsigned
sourceSize, IndexingType sourceType)

ALWAYS_INLINE?