[webkit-reviews] review granted: [Bug 167991] JSC: Intl API should ignore encoding when parsing BCP 47 language tag from ISO 15897 locale string (passed via LANG) : [Attachment 345813] Patch

[bugzilla-daemon at webkit.org]

Michael Catanzaro <mcatanzaro at igalia.com> has granted Andy VanWagoner
<andy at vanwagoner.family>'s request for review:
Bug 167991: JSC: Intl API should ignore encoding when parsing BCP 47 language
tag from ISO 15897 locale string (passed via LANG)
https://bugs.webkit.org/show_bug.cgi?id=167991

Attachment 345813: Patch

https://bugs.webkit.org/attachment.cgi?id=345813&action=review




--- Comment #20 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 345813
  --> https://bugs.webkit.org/attachment.cgi?id=345813
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=345813&action=review

> Source/JavaScriptCore/runtime/IntlObject.cpp:144
> +	   return String::fromUTF8(buffer.data(), length);

You're right: it's safe to pass directly to the String constructor if you know
the data is all ASCII, so my comment was totally wrong and the way you had it
before was better.

> Source/JavaScriptCore/runtime/IntlObject.cpp:609
> +    for (const auto &language : languages) {

The & gets attached to the type, not the variable name:

const auto& language