[webkit-reviews] review granted: [Bug 187942] [Web Animations] REGRESSION: transition added immediately after element creation doesn't work : [Attachment 345786] Patch

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Antoine Quint <graouts at apple.com>'s
request for review:
Bug 187942: [Web Animations] REGRESSION: transition added immediately after
element creation doesn't work
https://bugs.webkit.org/show_bug.cgi?id=187942

Attachment 345786: Patch

https://bugs.webkit.org/attachment.cgi?id=345786&action=review




--- Comment #10 from Dean Jackson <dino at apple.com> ---
Comment on attachment 345786
  --> https://bugs.webkit.org/attachment.cgi?id=345786
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=345786&action=review

> Source/WebCore/animation/DocumentTimeline.cpp:433
> +	   }

Don't you want an else continue here? You continue from the inner loop but
would just loop through the remainder of the animations. unless you need to
resolve the style for all of them, but i don't think so.

> LayoutTests/webanimations/accelerated-transition-by-removing-property.html:22
> +setTimeout(() => {
> +    target.style.removeProperty("transform");
> +    target.style.transition = "transform 10s linear";
> +    setTimeout(() => {

You should add a test that has multiple animations, only one of which is
hardware composited.